This repository was archived by the owner on May 19, 2025. It is now read-only.
fix(styles): add RTL support for date range edge & select styles #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subash-Chand-Thakuri
requested review from
burakcan,
mkg0 and
kamyar
as code owners
|
component was not released since 2021. I'm curious because the component is quite ld now and has compatibility problems with new versions of react. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
-> This PR is UI Styles Changes
What types of changes does your code introduce?
-> This PR adds RTL (Right-To-Left) support for date selection ranges and also corrects the direction of the Next and Previous buttons in the calendar UI.
Put an
xin the boxes that applyDescription
Improves compatibility for RTL languages by adjusting border-radius and positioning styles using :dir(rtl) and :dir(ltr) selectors for the date range selection visibility and preview hovering effect. Here are some of the evidences:
Before fixing:
After fixing:
Video:
https://www.loom.com/share/bafd166e3a9b45b58675b96f72668b0a?sid=3d85d4a3-c5a1-423c-9d30-1f140830c63e