Repository navigation
fix(provider-html-local): clamp over-long ranges and serve empty files - #421
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local capture server that serves a staged HTML Program and its media to Chrome refuses two requests it should answer:
Rangewas validated as the range0-(size-1), which is0--1for an empty file, so an empty staged asset was answered 416 instead of 200.A request without
Rangeis now always a complete200(an empty file getsContent-Length: 0and an empty body). A bounded range clamps its last position to the end of the file.bytes=N-and in-range requests are answered as before. A first position at or past the end, and a reversed range, are still 416.The new
packages/provider-html-local/test/server.test.tsstarts the server on a temporary directory and checks full, bounded, open-ended, over-long, past-the-end and reversed ranges, plus an empty file. It fails on main and passes with the change.Checks run:
node --import tsx --test packages/provider-html-local/test/server.test.tsnode --import tsx --test packages/provider-html-local/test/stage.test.ts packages/provider-html-local/test/frames.test.ts(8 passed)