Repository navigation
fix(result): look up Output names as own keys only - #428
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build Result Output lookups index
manifest.outputs[name]directly, so names inherited fromObject.prototypecount as Outputs:The name comes straight from the command line.
toStringreturns a function rather thanundefined, so the "no such Output" branch is skipped and the code reads.value.kindfrom the function. The presentation update in the same file already guards display names withObject.hasOwn(manifest.outputs, name). The other lookups did not.Every Output lookup now goes through
Object.hasOwn, asoutputDisplayNamesalready does:updatePresentation;store.ts, and the forwarding walk that followsbuild-outputlinks;result-exportand thehistoryquery in the CLI.A name that is not an own Output now gets the existing "has no Output" error or an
undefinedresult.The result test now checks that highlighting
constructoris rejected and that resolvingtoStringreturnsundefined. It fails on main and passes with the change. This is input hardening; ordinary Output names behave exactly as before.Checks run:
node --import tsx --test packages/result/test/*.test.ts packages/cli/test/build-results.test.ts(25 passed)