Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/provider-html-local/src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@ const mediaTypes: Readonly<Record<string, string>> = {
/** Serve one staged program and its lazily decoded frames to local capture pages. */
export async function serveHtmlProgram(root: string): Promise<{ readonly url: string; close(): Promise<void> }> {
const base = resolve(root);
let origin: string | undefined;
const server = createServer(async (request, response) => {
try {
// Only the capture page addresses this server, always by its loopback URL.
// A page reaching it through another name (DNS rebinding) is refused.
if (request.headers.host !== origin) { response.writeHead(421).end(); return; }
const pathname = decodeURIComponent(new URL(request.url ?? "/", "http://127.0.0.1").pathname);
const path = resolve(base, pathname === "/" ? "index.html" : `.${pathname}`);
if (path !== base && !path.startsWith(`${base}${sep}`)) {
Expand Down Expand Up @@ -45,6 +49,7 @@ export async function serveHtmlProgram(root: string): Promise<{ readonly url: st
});
const address = server.address();
if (address === null || typeof address === "string") throw new Error("HTML Program server did not bind a TCP port");
origin = `127.0.0.1:${address.port}`;
return {
url: `http://127.0.0.1:${address.port}/`,
close: () => new Promise<void>((resolveClose, reject) => server.close(error => error ? reject(error) : resolveClose())),
Expand Down
34 changes: 34 additions & 0 deletions packages/provider-html-local/test/server.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import assert from "node:assert/strict";
import test from "node:test";
import { mkdtemp, rm, writeFile } from "node:fs/promises";
import { request } from "node:http";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { serveHtmlProgram } from "../src/server.js";

function get(url: string, host?: string): Promise<number> {
return new Promise((resolveStatus, reject) => {
const target = new URL(url);
const outgoing = request({ hostname: target.hostname, port: target.port, path: target.pathname,
headers: host === undefined ? {} : { host } }, (response) => {
response.resume();
response.on("end", () => resolveStatus(response.statusCode ?? 0));
});
outgoing.on("error", reject);
outgoing.end();
});
}

test("the capture server answers only its own loopback host, so a rebound name cannot read staged material", async (t) => {
const root = await mkdtemp(join(tmpdir(), "hypit-html-server-"));
t.after(() => rm(root, { recursive: true, force: true }));
await writeFile(join(root, "index.html"), "<!doctype html><p>program</p>");
const server = await serveHtmlProgram(root);
t.after(() => server.close());
const { host, port } = new URL(server.url);
assert.equal(await get(server.url), 200);
assert.equal(await get(server.url, host), 200);
assert.equal(await get(server.url, `attacker.example:${port}`), 421);
assert.equal(await get(server.url, `localhost:${port}`), 421);
assert.equal(await get(server.url, "localhost"), 421);
});
Loading