-
Notifications
You must be signed in to change notification settings - Fork 442
Rate-limit emails sent by the same user in a period of time #9462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5a2d3c
to
5a0d099
Compare
5a0d099
to
0a23f35
Compare
mtomilov
commented
Apr 10, 2025
mtomilov
commented
Apr 10, 2025
0a23f35
to
615fce8
Compare
mtomilov
commented
Apr 10, 2025
mtomilov
commented
Apr 10, 2025
615fce8
to
14a98ad
Compare
c9f07f3
to
d70c942
Compare
acelaya
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I tested it by setting DAILY_SENDER_MENTION_LIMIT = 3
. After the third mention, I was not able to send more, and the warning message was logged
532c933
to
a96397d
Compare
a96397d
to
6e8a8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9411
Here we rate-limit emails sent by a single user to 100 within the last 24h to prevent abuse.
Testing
DAILY_SENDER_MENTION_LIMIT
to a lower value like 5devdata_admin
devdata_user
mail
folderlimit reached
line in celery logs