Add the Annotation.moderation_status column #9476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This column will support the existing feature stored in AnnotationModeration and new features based on the new statuses.
seanh
reviewed
Apr 22, 2025
Comment on lines
+17
to
+21
| class ModerationStatus(Enum): | ||
| APPROVED = "APPROVED" | ||
| PENDING = "PENDING" | ||
| DENIED = "DENIED" | ||
| SPAM = "SPAM" |
Contributor
There was a problem hiding this comment.
I posted a comment on the POC about whether we want to use strings in the DB here or just ints?
Contributor
Author
There was a problem hiding this comment.
This type of enum is stored in the DB as an integer. I reckon this is the right way way to do "translate strings to integers" when you do not care about the actual integer value.
If we wanted to just rename a value we might not bother on the DB or we could alter the type:
ALTER TYPE name RENAME value deniedtorejected;
that would just change the type and no rows would need to be updated.
seanh
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This column will support the existing feature stored in AnnotationModeration and new features based on the new statuses.
Migration over: #9475