Skip to content

Backfill moderation status based on AnnotationModeration #9480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcospri merged 1 commit into from
Apr 23, 2025
Merged

Backfill moderation status based on AnnotationModeration #9480

marcospri merged 1 commit into from
Apr 23, 2025

Conversation

@marcospri
Copy link
Contributor

@marcospri marcospri commented Apr 15, 2025 •
edited
Loading

Testing

  • Flag and hide an annotation in main
  • Switch to this branch and run the migration:
PYTHONPATH=. tox -e dev --run-command 'alembic upgrade head'
dev run-test-pre: PYTHONHASHSEED='1927699192'
dev run-test-pre: commands[0] | pip-sync-faster requirements/dev.txt --pip-args --disable-pip-version-check
dev run-test: commands[0] | alembic upgrade head
2025-04-15 15:15:52 1837985 alembic.runtime.migration [INFO] Context impl PostgresqlImpl.
2025-04-15 15:15:52 1837985 alembic.runtime.migration [INFO] Will assume transactional DDL.
2025-04-15 15:15:52 1837985 alembic.runtime.migration [INFO] Running upgrade 2aacaede8542 -> 077e087027b1, Backfill moderation_status based on AnnotationModeration.
        Updated annotation rows as DENIED: 1

marcospri
marcospri commented Apr 15, 2025
View reviewed changes
h/migrations/versions/077e087027b1_backfill_moderation_status_based_on_.py
SET moderation_status = 'DENIED'
FROM annotation_moderation
WHERE annotation.id = annotation_moderation.annotation_id
AND annotation.moderation_status is null
Copy link
Contributor Author

@marcospri marcospri Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't override anything if we already have set a status.

@marcospri marcospri requested a review from seanh April 15, 2025 13:18
@marcospri marcospri force-pushed the moderation-writes branch 4 times, most recently from fbe18fc to b7e4bb7 Compare April 23, 2025 14:02
Base automatically changed from moderation-writes to main April 23, 2025 14:14
@marcospri marcospri force-pushed the moderation-backfill branch from 31f7046 to 4f9688a Compare April 23, 2025 14:41
@marcospri marcospri merged commit 0391d9d into main Apr 23, 2025
11 checks passed
@marcospri marcospri deleted the moderation-backfill branch April 23, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seanh seanh seanh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcospri @seanh