Open
Conversation
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
StefanScherer
requested changes
Jul 9, 2020
Member
StefanScherer
left a comment
StefanScherer
left a comment
There was a problem hiding this comment.
Thank you. That looks good so far.
Could you update the usage and the README.md that it‘s possible to use —file multiple times?
At least the README should show an example for multiple files as you showed in the PR description.
Adding a test would be super cool, if you have time.
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Author
|
Hi, thanks for the feedback. I've added some additional info on how to copy multiple files and also added a test case. |
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
geoff-coppertop
approved these changes
Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this flash utility to write raspian and ubuntu images but I would like to copy multiple custom files to /boot.
This pull request adds the ability to do this with multiple
-F/--fileflags like:flash --file usercfg.txt --file network-config ...