Skip to content

chore: hyprland-rs 0.4.0-beta.2#119

Merged
shivros merged 1 commit intohyprland-community:mainfrom
shivros:mw/hyprland-0.4.0-beta-2
Jan 12, 2025
Merged

chore: hyprland-rs 0.4.0-beta.2#119
shivros merged 1 commit intohyprland-community:mainfrom
shivros:mw/hyprland-0.4.0-beta-2

Conversation

@shivros
Copy link
Collaborator

@shivros shivros commented Jan 12, 2025

Description

Updates hyprland-rs to 0.4.0-beta.2

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Relying on existing unit tests and testing it locally on my system.

@shivros shivros requested a review from cyrinux January 12, 2025 03:55
@shivros
Copy link
Collaborator Author

shivros commented Jan 12, 2025

The only test failures are pre-existing and not related to the changes.

@shivros shivros marked this pull request as ready for review January 12, 2025 03:56
@shivros shivros marked this pull request as draft January 12, 2025 03:59
@cyrinux
Copy link
Collaborator

cyrinux commented Jan 12, 2025

It looks good for me.

But any reason you remove silent?

For info, It will be very verbose for end user if a event if not handle by hyperland-rs - if this feature flag still exist.
Maybe we should if possible have a set of feature for dev and release mode?

@shivros
Copy link
Collaborator Author

shivros commented Jan 12, 2025

It looks good for me.

But any reason you remove silent?

For info, It will be very verbose for end user if a event if not handle by hyperland-rs - if this feature flag still exist. Maybe we should if possible have a set of feature for dev and release mode?

Yeah, @cyrinux I removed silent because it was removed in hyprland-community/hyprland-rs@b4ff36a. I don't think there's any equivalent, currently.

@shivros shivros force-pushed the mw/hyprland-0.4.0-beta-2 branch from e18daf4 to 43a73ed Compare January 12, 2025 16:43
@shivros shivros marked this pull request as ready for review January 12, 2025 16:44
@shivros
Copy link
Collaborator Author

shivros commented Jan 12, 2025

It looks to me like the verbose logging for unknown events was removed (hyprland-community/hyprland-rs@b4ff36a#diff-c8a4a4f1c07565340179fe7fbd175cd1cabf756f8010591742a6a5993227724fL529-L539) at the same time, so the silent feature is no longer necessary.

@shivros shivros merged commit ba126d5 into hyprland-community:main Jan 12, 2025
4 checks passed
@shivros shivros deleted the mw/hyprland-0.4.0-beta-2 branch January 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants