Skip to content

Conversation

@vaxerski
Copy link
Member

Adds loading of icc profiles for the properties we support

ref #9064

@vaxerski
Copy link
Member Author

@fufexan can we get nix

@vaxerski
Copy link
Member Author

can you guys let me know if this works well? I have done very limited testing.

@Flat
Copy link

Flat commented Dec 23, 2025

can you guys let me know if this works well? I have done very limited testing.

Hyprland 0.52.0 built from branch icc-support at commit a3520d917afdbbd084c76a8daa8ce1d6c02811f5 clean (cm: add ICC profile loading).
Date: Tue Dec 23 11:06:26 2025
Tag: v0.52.0-183-ga3520d91, commits: 6742

Libraries:
Hyprgraphics: built against 0.4.0, system has 0.4.0
Hyprutils: built against 0.11.0, system has 0.11.0
Hyprcursor: built against 0.1.13, system has 0.1.13

Hyprlang: built against 0.6.7, system has 0.6.7
Aquamarine: built against 0.10.0, system has 0.10.0

Do not see anything in the logs showing it is loading the ICC profile, or rather nothing icc at all. What am I doing wrong there?

monitorv2 {
    output = DP-2
    mode = [email protected]
    scale = 1
    position = 0x0
    bitdepth = 10
    cm = dcip3
    sdr_min_luminance = 0.0005
    sdr_max_luminance = 250
    icc = /home/flat/.config/icc/dell-icc-profile.icm
}
monitorv2 {
    output = DP-1
    mode = [email protected]
    scale = 1
    position = auto-up
    bitdepth = 10
    cm = dcip3
    sdr_min_luminance = 0.005
    sdr_max_luminance = 250
    icc = /home/flat/.config/icc/dell-icc-profile.icm
}

hyprland.log

@vaxerski
Copy link
Member Author

oh oops, I think I forgot v2

@vaxerski
Copy link
Member Author

my bad should work now

@vaxerski
Copy link
Member Author

it should dump what we were able to decode from the icc into the log like so if it loaded successfully

image

@Flat
Copy link

Flat commented Dec 23, 2025

Yup, it does attempt to load now. Unfortunately looks like the only ICC profile for my monitor is split-trc, so I won't be able to assist much with testing here.

failed: Hyprland cannot represent split-trc profiles yet

@vaxerski
Copy link
Member Author

I've added logging of the trc to the debug output, can you post the icc data dump here?

@Flat
Copy link

Flat commented Dec 24, 2025

Sure, here you go!
iccdump.log

@vaxerski
Copy link
Member Author

thanks, despite xmas :P

@vaxerski
Copy link
Member Author

vaxerski commented Dec 24, 2025

This should work. I've loaded my ICC profile and it does seem to change the colors on my panel a bit, but without a colorimeter I have no way of verifying if it's correct. Please load your ICC and let me know.

@Flat
Copy link

Flat commented Dec 24, 2025

It does seem to change the colors. I've ordered a colorimeter to verify though, should have it within a week.

@vaxerski
Copy link
Member Author

talk about dedication. I do think its wrong, sway's is different.

@vaxerski
Copy link
Member Author

@UjinT34 would you mind checking the LUT shader changes? I'm quite sure I am doing something wrong there. Shadows are a tad too bright I think.

Can't say for sure without a colorimeter but they do look a bit flat and weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants