-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
cm: add ICC profile loading #12711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cm: add ICC profile loading #12711
Conversation
|
@fufexan can we get nix |
|
can you guys let me know if this works well? I have done very limited testing. |
Do not see anything in the logs showing it is loading the ICC profile, or rather nothing icc at all. What am I doing wrong there? |
|
oh oops, I think I forgot v2 |
|
my bad should work now |
|
Yup, it does attempt to load now. Unfortunately looks like the only ICC profile for my monitor is split-trc, so I won't be able to assist much with testing here.
|
|
I've added logging of the trc to the debug output, can you post the icc data dump here? |
|
Sure, here you go! |
|
thanks, despite xmas :P |
|
This should work. I've loaded my ICC profile and it does seem to change the colors on my panel a bit, but without a colorimeter I have no way of verifying if it's correct. Please load your ICC and let me know. |
|
It does seem to change the colors. I've ordered a colorimeter to verify though, should have it within a week. |
|
talk about dedication. I do think its wrong, sway's is different. |
|
@UjinT34 would you mind checking the LUT shader changes? I'm quite sure I am doing something wrong there. Shadows are a tad too bright I think. Can't say for sure without a colorimeter but they do look a bit flat and weird. |

Adds loading of icc profiles for the properties we support
ref #9064