output: fix tearing with direct scanout and hardware cursor #10020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalco
changed the title
ikalco
force-pushed
the
fix_tearing_with_ds
branch
from
6ba9c42 to
531d79a
Compare
|
DS doesn't work with SW cursors. Might work with invisible SW cursors if the code allows it. |
|
is there still any blocking for this PR? I've been using this patch for weeks and it's okay. |
I don't think its finished, gotta look over it still |
|
@ikalco rebase? |
…AnGeD dUrInG AsYnC fLiP" on crtc_x
ikalco
force-pushed
the
fix_tearing_with_ds
branch
from
2d30319 to
002af6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
related #9858 and #9890
this pr tries to fix tearing when its combined with other stuff (ds, hw cursor, maybe more? idk)
also draft cause seems to me some other old mechanisms (pre aq) may still be interfering with new ones
note for future me:
the hardware cursors breaking tearing may be because moving cursor schedules frame,
which might stop events.frame.emit() from being called in aq,
which means monitor tearing render never happens...
also look into whether tearingState.frameScheduledWhileBusy and tearingState.busy is still needed? why not use aq schedule frame and present event?
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
draft