Allow DS for surfaces with inert subsurfaces #12133
Open
+26
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njdom24
force-pushed
the
ds-empty-subsurfaces
branch
from
0d50e08 to
8c6f6b9
Compare
njdom24
force-pushed
the
ds-empty-subsurfaces
branch
from
8c6f6b9 to
84d6c9e
Compare
idea aint stupid, code sux tho |
vaxerski
reviewed
Oct 27, 2025
njdom24
force-pushed
the
ds-empty-subsurfaces
branch
from
84d6c9e to
a5dae7c
Compare
njdom24
force-pushed
the
ds-empty-subsurfaces
branch
from
a5dae7c to
ff44af9
Compare
vaxerski
reviewed
Oct 29, 2025
njdom24
force-pushed
the
ds-empty-subsurfaces
branch
from
ff44af9 to
4eff4de
Compare
njdom24
force-pushed
the
ds-empty-subsurfaces
branch
2 times, most recently
from
bd7e476 to
62cdfe0
Compare
vaxerski
reviewed
Nov 1, 2025
src/protocols/core/Compositor.cpp
Outdated
| if (subsurface.expired() || subsurface->m_surface.expired()) | ||
| return true; | ||
|
|
||
| auto surf = subsurface->m_surface.lock(); |
There was a problem hiding this comment.
locking is redundant. Check operator bool on WP and deref a weak
src/protocols/core/Compositor.cpp
Outdated
| bool CWLSurfaceResource::hasVisibleSubsurface() { | ||
| for (auto const& subsurface : m_subsurfaces) { | ||
| if (subsurface) { | ||
| if (subsurface.expired() || subsurface->m_surface.expired()) |
There was a problem hiding this comment.
prefer operator bool which is the inverse of expired
njdom24
changed the title
njdom24
force-pushed
the
ds-empty-subsurfaces
branch
from
62cdfe0 to
91045b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Gets DS working with Gamescope.
gamescope --mangoappdisables DS forsubsurfaces, and toggling it on/off withShift_R+F12works as expected.Note: Gamescope doesn't do hardware cursors with its Wayland backend, so moving the cursor will go in/out of DS. This outcome is the same as Sway, and works fine for games with captured cursors, so I think it's okay. Given that toggling
mangoappdoesn't cause this stutter, it's probably a Gamescope issue.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
My knowledge of subsurfaces is lacking. If this is stupid, please say so.
Is it ready for merging, or does it need work?
Ready