cm: higher-quality tonemapping #12204
Draft
+43
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njdom24
force-pushed
the
screenshare-cm-brightness
branch
from
3df2f92 to
5e53f84
Compare
njdom24
changed the title
njdom24
force-pushed
the
screenshare-cm-brightness
branch
from
5e53f84 to
3f2aefa
Compare
njdom24
force-pushed
the
screenshare-cm-brightness
branch
from
3f2aefa to
62a2099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This PR is targetting screenshare.
Inspired by KWin. Updates the tonemapper to use the
srcimageDescription's luminance info instead of throwing it away. Also scares the reference luminance to match that of the destination, preventing over-bright screenshots / recordings.Also tossed in a quick fix missed from #12094, which prevents overly-dark screenshares in SDR when
render:cm_sdr_eotf> 0.HDR screenshot tonemapped to SDR:
SDR screenshot:
I also considered a simple luminance multiplier as a proof-of-concept when getting started. This is what that would look like by keeping the current
tonemapand simply multiplying the end result by80.0 / 203.0:Versus this PR:
FWIW, The first image is actually closer to how this game in particular looks in SDR.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I'm not super confident in the "correctness" of tonemapper changes (really just looked at prior art), but it does improve HDR screenshares immensely.
Is it ready for merging, or does it need work?
Ready for testing. I want to take some time to look over it again myself though.