Skip to content

Conversation

@EvilLary
Copy link
Contributor

@EvilLary EvilLary commented Nov 29, 2025

Describe your PR, what does it fix/add?

fixes #11287

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Since exec rules have a 1 second timeout, is it better to postpond the creation of the rule until CAsyncDialogBox::open call, or is the current approach fine?

Is it ready for merging, or does it need work?

Only tested it with simple client idk any other, but works great

Edit: Actually it doesn't work with special workspaces. Workspace rule doesn't work with special workspace ids, only their names like special:magic --- should be fixed

@EvilLary EvilLary marked this pull request as draft November 29, 2025 21:52
@EvilLary EvilLary marked this pull request as ready for review November 29, 2025 23:33
@EvilLary EvilLary force-pushed the anrdialog branch 2 times, most recently from a5347f9 to 0da240c Compare December 3, 2025 16:16
@EvilLary EvilLary requested a review from vaxerski December 3, 2025 18:14
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tests needed

@EvilLary
Copy link
Contributor Author

EvilLary commented Dec 7, 2025

Done, tests are gonna take longer now :P, gotta wait for anrdialogs

@EvilLary
Copy link
Contributor Author

EvilLary commented Dec 7, 2025

Huh, does hyprland-dialog fails to load in the test vm?

log snippet
vm-test-run-hyprland-tests> anrdialogs Should pop up on parent's workspace
vm-test-run-hyprland-tests> anrdialog: regular workspaces
vm-test-run-hyprland-tests> Passed: getFromSocket("/dispatch workspace 2"). Got ok
vm-test-run-hyprland-tests> Passed: str contains workspace: 2.
vm-test-run-hyprland-tests> Passed: getFromSocket("/dispatch workspace 1"). Got ok
vm-test-run-hyprland-tests> libEGL warning: egl: failed to create dri2 screen
vm-test-run-hyprland-tests> libEGL warning: egl: failed to create dri2 screen
vm-test-run-hyprland-tests> libEGL warning: NEEDS EXTENSION: falling back to kms_swrast
vm-test-run-hyprland-tests> KMS: DRM_IOCTL_MODE_CREATE_DUMB failed: Permission denied
vm-test-run-hyprland-tests> KMS: DRM_IOCTL_MODE_CREATE_DUMB failed: Permission denied
vm-test-run-hyprland-tests> Timed out waiting for windows
vm-test-run-hyprland-tests> Passed: str contains windows: 0.
vm-test-run-hyprland-tests> Failed: getFromSocket("/dispatch focuswindow class:hyprland-dialog"), expected ok, got No such window found. Source: hyprtester/src/tests/main/misc.cpp@56.
vm-test-run-hyprland-tests> Failed: str should contain "workspace: 2" but doesn't. Source: hyprtester/src/tests/main/misc.cpp@58. Haystack is:
vm-test-run-hyprland-tests> Invalid

@EvilLary EvilLary requested a review from vaxerski December 7, 2025 10:22
@vaxerski
Copy link
Member

vaxerski commented Dec 9, 2025

maybe its not open yet? Also remember dialog exits only once its closed?

@EvilLary
Copy link
Contributor Author

EvilLary commented Dec 9, 2025

It's trying to open but fails. I tried runnig hyprland-dialog in a vm without 3d acceleration and it was failing with the same error messages as above

@vaxerski
Copy link
Member

the thing is that the vm should have 3d accel. @fufexan ?

@fufexan
Copy link
Member

fufexan commented Dec 13, 2025

the thing is that the vm should have 3d accel. @fufexan ?

I thought software rendering would do 3d. Maybe I'm wrong?

@vaxerski
Copy link
Member

well it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANR should pop up on the workspace of the parent

3 participants