-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
anr: open anr dialog on parent's workspace #12509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a5347f9 to
0da240c
Compare
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm tests needed
|
Done, tests are gonna take longer now :P, gotta wait for anrdialogs |
|
Huh, does hyprland-dialog fails to load in the test vm? log snippet |
|
maybe its not open yet? Also remember dialog exits only once its closed? |
|
It's trying to open but fails. I tried runnig hyprland-dialog in a vm without 3d acceleration and it was failing with the same error messages as above |
|
the thing is that the vm should have 3d accel. @fufexan ? |
I thought software rendering would do 3d. Maybe I'm wrong? |
|
well it should |
Describe your PR, what does it fix/add?
fixes #11287
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Since exec rules have a 1 second timeout, is it better to postpond the creation of the rule until
CAsyncDialogBox::opencall, or is the current approach fine?Is it ready for merging, or does it need work?
Only tested it with simple client idk any other, but works great
Edit:
Actually it doesn't work with special workspaces. Workspace rule doesn't work with special workspace ids, only their names like--- should be fixedspecial:magic