Skip to content

Make hyprctl listener non-blocking and bounded #12587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rtur2003 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make hyprctl listener non-blocking and bounded #12587

Rtur2003 wants to merge 1 commit into from
+30 −24

Conversation

@Rtur2003
Copy link
Contributor

@Rtur2003 Rtur2003 commented Dec 7, 2025 •
edited
Loading

Summary

  • set listener/accepted sockets to SOCK_NONBLOCK and remove the blocking poll
  • bound request size to 64KiB and tighten read/accept error handling

Testing

  • manual: run hyprctl commands; verify no hangs and large input is rejected safely

@Rtur2003
Made hyprctl IPC non-blocking and bounded: listener socket and accept…
f2b8abc 
…ed fds use SOCK_NONBLOCK, removed the blocking poll, added a 64KiB request cap, and clearer read/accept error handling
vaxerski
vaxerski reviewed Dec 7, 2025
View reviewed changes
src/debug/HyprCtl.cpp
if (messageSize == 0)
break;
request.append(readBuffer.data(), rc<size_t>(messageSize));
if (messageSize < static_cast<int>(readBuffer.size()))
Copy link
Member

@vaxerski vaxerski Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sc<>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaxerski vaxerski vaxerski left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

core debug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rtur2003 @vaxerski