Skip to content

Guard plugin longjmp when jump buffer isn’t primed #12589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rtur2003 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Guard plugin longjmp when jump buffer isn’t primed #12589

Rtur2003 wants to merge 1 commit into from

Conversation

@Rtur2003
Copy link
Contributor

@Rtur2003 Rtur2003 commented Dec 7, 2025 •
edited
Loading

Summary

  • track whether the hook jump buffer is initialized before longjmp
  • skip the jump when missing/invalid and fall back to crash reporting

Testing

  • manual: load a faulting plugin; verify no longjmp into uninitialized buffer and crash path is taken

@Rtur2003
Prevented longjmp into an uninitialised buffer during plugin faults b…
e8a9615 
…y tracking when the hook jump buffer is actually primed; a missing/invalid buffer now skips the jump and falls back to crash reporting
vaxerski
vaxerski reviewed Dec 7, 2025
View reviewed changes
src/managers/HookSystemManager.hpp
std::vector<SCallbackFNPtr>* getVecForEvent(const std::string& event);

bool m_currentEventPlugin = false;
bool m_hookFaultJumpBufReady = false;
Copy link
Member

@vaxerski vaxerski Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bool does nothing, it's never used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaxerski vaxerski vaxerski left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

core managers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rtur2003 @vaxerski