Skip to content

Normalize timespec borrow/overflow and add regression tests #12590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rtur2003 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Normalize timespec borrow/overflow and add regression tests #12590

Rtur2003 wants to merge 10 commits into from
+169 −35

Conversation

@Rtur2003
Copy link
Contributor

@Rtur2003 Rtur2003 commented Dec 7, 2025 •
edited
Loading

Summary

  • normalize timespec nsec overflow/borrow before conversions and expose helper for tests
  • fix system_clock sec/nsec reconstruction drift
  • add regression tests for Time::toTimespec/fromTimespec and diff/normalize edge cases

Testing

  • tests: ctest (gtest helpers/Time*, helpers/TimeDiff*)

Rtur2003 added 10 commits December 7, 2025 21:46
@Rtur2003
Added a small gtest to cover Time::toTimespec/fromTimespec roundtrip …
1bd020f 
…tolerance
@Rtur2003
helpers/time: fix timespec borrow
e177da5
@Rtur2003
elpers/time: fix timespec borrow
af5bf8e
@Rtur2003
elpers/time: fix timespec borrow
7bb2dd3
@Rtur2003
Corrected Time::secNsec(system_tp) to use system_clock durations, kee…
49777f1 
…ping conversions consistent
@Rtur2003
Added a system-clock roundtrip regression test to catch drift when re…
256b52c 
…constructing from sec/nsec parts
@Rtur2003
Preserved earlier nanosecond-borrow fix and existing steady roundtrip…
3671040 
… coverage
@Rtur2003
sanitize incoming timespecs via normalization before conversion, reu…
09cedd2 
…se that in conversions, and expose the helper through detail for testing. Borrow logic unchanged but now robust to nsec overflow
@Rtur2003
eclared detail::normalize alongside detail::diff for testability.
c9389b2
@Rtur2003
ightened chrono literal usage, unsigned expectations, and added a reg…
2f99fe4 
…ression test ensuring nsec overflow is normalized into

    whole seconds.
vaxerski
vaxerski reviewed Dec 7, 2025
View reviewed changes
scripts/generateShaderIncludes.sh
@@ -1,24 +1,49 @@
#!/bin/sh

# dash-compatible and space-safe shader include generator. @Rtur2003
Copy link
Member

@vaxerski vaxerski Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these changes

src/helpers/time/Time.cpp

namespace Time::detail {

sec_nsec diff(const sec_nsec& newer, const sec_nsec& older) {
Copy link
Member

@vaxerski vaxerski Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time::detail::diff instead of namespace {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaxerski vaxerski vaxerski left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

core helpers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rtur2003 @vaxerski