Open
Conversation
UjinT34
force-pushed
the
refactor-6-glrenderer
branch
from
bb8758d to
794afe4
Compare
This was referenced Mar 2, 2026
UjinT34
force-pushed
the
refactor-6-glrenderer
branch
from
794afe4 to
b681b72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Moved some render data inside render pass elements.
Those elements are used for rendering instead of direct
g_pHyprOpenGLcalls.Use
IFramebuffer::readPixelsto get image data from FBs.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
g_pHyprOpenGLremains exposed and can be used by plugins but some bits might be moved inside render pass elements and renderer.Render pass elements might not provide the exact 1:1 match to direct
g_pHyprOpenGLcalls.Render pass elements might not use correct damage and clip boxes/regions (meaning larger damage/clips than needed)
Part 6 #13272 refactors
Is it ready for merging, or does it need work?
Includes #13485 and should be reviewed after that.
Ready.