Implement new Input Capture protocol

[3l0w]

Describe your PR, what does it fix/add?

This PR implements the input capture protocol defined in hyprwm/hyprland-protocols#8.
It also fixed a bug where wl_output::geometry x and y arguments where always 0.
The wl_output::geometry event is now sent when the output layout change (Help to follow x and y modifications).

Is it ready for merging, or does it need work?

It still need work, like sending the keyboard layout.

TODO List:

• See if the fd multiplication problem is fixed
• Calculate the invalids barriers on SetPointerBarriers
• Replace the trash impl of get_line_intersection by one that follow the specs
• Warp pointer when the cursor is released by the capturing program
• Move most of the impl to Hyprland
• Impl some kind of security around Permission Manager: add permission management for screencopy #9930, maybe move some of the impl ive done here to Hyprland
• Fix the isLock shenanigans
• See if i limit to only one client, (for now multiple clients can connect, first arrive with his zones, first to be triggered)
• Fix unable to access tty when captured

[3l0w]

just a general question. will this be released in the next release or will it be taking a while, considering it's marked as draft

Idk when it will be finished. if you need it, build it yourself

[littleblack111]

With your fork, will kvm software such as input leap work out of the box?

[3l0w]

Yes and i am it to test
But only the capture part (server) will work for now

[littleblack111]

wow it was really troublesome compiling xdg-desktop-portal-hyprland. have to copy over the protocol to my /usr/share/hyprland-protocols(or clone it there), or i just removed the if line and forced it to get it from the repo.

but, it seems to just fail in input-leap:

[2024-10-09T19:43:32] ERROR: Failed to initialize InputCapture session, quitting: CreateSession failed

it was giving a error that it cant find the input-leap location before installing your hyprland & xdg-desktop-portal-hyprland fork. that error is gone. but still failed.

[3l0w]

Its strange that you have to copy the protocol file over, did you clone the submodules ? (git submodule init && git submodule update)
Also i forget to mention that you need to copy the file hyprland.portal over to a location that the xdg-desktop-portal will pick it up (on my arch install its over /usr/share/xdg-desktop-portal/portals/hyprland.portal) and dont forget to restart the xdg-desktop-portal after that.
Without that xdg-desktop-portal will not pickup xdph when forwarding InputCapture requests.

[littleblack111]

Its strange that you have to copy the protocol file over, did you clone the submodules ? (git submodule init && git submodule update)

its the cmakelist file, it tried to grab from /usr/share/hyprland-protocols if exist, which doesn't have your protocol as it's not merged in the hyprland-protocol repo, thus i made it only grab from the gh repo.
as seen in here:

if(HYPRLAND_PROTOS_FOUND)
  set(HYPRLAND_PROTOCOLS "${HYPRLAND_PROTOS_PREFIX}/share/hyprland-protocols")
else()
  set(HYPRLAND_PROTOCOLS "${CMAKE_SOURCE_DIR}/subprojects/hyprland-protocols")
endif()

i see, ill try that

EDIT: in the install(from README: cmake -DCMAKE_INSTALL_LIBEXECDIR=/usr/lib -DCMAKE_INSTALL_PREFIX=/usr -B build cmake --build build sudo cmake --install build) seem to already copy hyprland.portal over

HOLLY! wow, not sure why, but i re-builded it and reinstalled it. and it WORKS! ty!

A suggestion is that, disable this when mouse or keyboard is being capture/binded by programs(e.g. games that uses mouse to move camera)

After two days of use. those are some feedbacks:
first of all, i just wanna say ty, cuz it works!

this is what im using:
kvm software -> input leap
server -> arch linux(with hyprland)
client -> macbook

but i have the following issues:

1. after a while, modifier keys such as super or ctrl will just be hold on the client, even if i press the button again. Until I relaunch/bind input capture, it will keep doing that
2. sometimes it will just randomly stop and i have relaunch/bind input capture
3. after going to macos, hyprland cursor wont disappear
4. Going from hyprland -> macos does seem to inhert/respect where the cursor is on hyprland, but when im switching back from macOS -> Hyprland, the cursor seem to instead inherit where it left off(described above, it does not disappear)
5. Clipboard sharing does not work
6. sometimes hyprland reload when its focused on the client can make everything go to nowhere(supposed their in the client, but client doesnt change), even if the client disconnect, changing tty doesnt work. or moving mouse, can only press the power button or ssh in and soft-reboot etc(kind of like the xwayland crash where when if you're intereacting with ur computer during a hyprland reload, it might crash xwayland)

[3l0w]

Thanks for the feedback tho i didn't encounter most of the issues you describe, but i will try to investigate it.
I am currently implementing a shortcut to force release the pointer and give it back to hyprland to prevent softlock.
The portal that i am implementing is not responsible for sharing the clipboard so there is really nothing i can do to make it work, it is a inputleap related issue.
I will try to implement something to make the cursor disappear, and also i need handle the cursor position send by the client when the capture is released maybe it will fix 4.
I am not yet sending modifier keys, i will impl it soon to see if it will fix 1 for you.

[littleblack111]

alright. ty! Appreciate it!

[3l0w]

The latest commit added a new shortcut: releaseinputcapture
This shortcut force release the capturing of inputs in case of softlock.

Personally, I bind it like this:

bind = $mainMod SHIFT, escape, releaseinputcapture

[littleblack111]

Nice! I'm currently on vacation without my laptop, so I'll try it when I get back

EDIT: Now i tried it, the new dispatcher works! ill try it when it locks down hyprland again and see if it works then

[littleblack111]

A suggestion is that, disable this when mouse or keyboard is being capture/binded by programs(e.g. games that uses mouse to move camera)

if thats not possible then maybe add a dispatcher so user can script it to do so

[littleblack111]

trim.44B51EBB-2916-40A4-BFBB-7EBA4AF42874.MOV

[3l0w]

A suggestion is that, disable this when mouse or keyboard is being capture/binded by programs(e.g. games that uses mouse to move camera)

if thats not possible then maybe add a dispatcher so user can script it to do so

You mean if a 3d game has kinda the mouse captured and move it to a border the input is captured and should not ?
I think its kinda a major issue if its the case, i will look into it

[3l0w]

trim.44B51EBB-2916-40A4-BFBB-7EBA4AF42874.MOV

If you have any steps to reproduce it it will be great

[littleblack111]

A suggestion is that, disable this when mouse or keyboard is being capture/binded by programs(e.g. games that uses mouse to move camera)

if thats not possible then maybe add a dispatcher so user can script it to do so

You mean if a 3d game has kinda the mouse captured and move it to a border the input is captured and should not ? I think its kinda a major issue if its the case, i will look into it

yes, for example my macbook is left, and i moved my cursor in game(that i captured) to left, it will eventually go to my mac screen. It does this in X11 too, but hoping it gets fixed as its unintended behavior and is very annoying since i have to quit my kvm software(input leap) in order to play games properly

[3l0w]

It is quite strange that you where able to still move the mouse in your primary computer.

[littleblack111]

not sure, it just happend randomly, but before it happend, i was impl a new feature and was opening a nested Hyprland, but i wont try again today cuz it's pretty late and ill sleep

[littleblack111]

A suggestion is that, disable this when mouse or keyboard is being capture/binded by programs(e.g. games that uses mouse to move camera)

if thats not possible then maybe add a dispatcher so user can script it to do so

You mean if a 3d game has kinda the mouse captured and move it to a border the input is captured and should not ? I think its kinda a major issue if its the case, i will look into it

related: https://www.reddit.com/r/kde/comments/u34lg0/wayland_gaming_and_mouse_capture/

[vaxerski]

cant comment on the tracy submodule bump: pls remov

overall nice work!

[vaxerski]

Also can bump required h-p in cmake + meson to 0.7.0 now https://github.com/hyprwm/hyprland-protocols/releases/tag/v0.7.0

[3l0w]

CI Nix builds seems to be borken because hyprland protocols is not up to date idk why

[fufexan]

CI Nix builds seems to be borken because hyprland protocols is not up to date idk why

Should work now.

[vaxerski]

this is still here

[3l0w]

this is still here

My bad, ive done a fixup every commit and removed the tracy bump

[vaxerski]

lgtm other than style.

Would it be feasible to write some tests for this? I don't know what the libei space looks like and if it's easy to write a simple client to send some requests

[vaxerski]

uninitialized primitive

[vaxerski]

oops?

[vaxerski]

no {}

[vaxerski]

forgot m_

[vaxerski]

forgot m_

[3l0w]

lgtm other than style.

Would it be feasible to write some tests for this? I don't know what the libei space looks like and if it's easy to write a simple client to send some requests

I can try at least

[vaxerski]

would be great, thanks.

[Kaysera]

I tried to compile this PR to setup a laptop but currently I think something changed because it currently does not compile without errors. How is this going? Great work, just asking out of curiosity 😁

[gac3k]

@3l0w apologize for pinging again, but do you need some help here? Can we take-over some bits anyhow just to speed things up a bit? :)

[3l0w]

Yeah maybe, i don't have the time right now to make the tests vaxerski ask, i will try to do today or tomorrow a rebase tho

[vaxerski]

if you don't have the time for tests that's okay, if enough people test this by using it we can merge.

Leave a 👍 under this comment if you've ran this and tested working. If I don't come back here within a few days, feel fre to tag me. :)

[3l0w]

Don't merge yet, i need to test a few issues that people seems to have encounter, i will tag you when its ready again