-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
keybinds: movewindow respect gaps out for floating windows #9360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
why should it though |
is that not what gaps_out is supposed to do? |
I also agree that movewindow should respect gaps! But I would prefer if it looked at a separate config option, since I personally prefer no gaps for tiling windows (but I do like gaps for floating windows). |
ac19cca
to
54fd5d8
Compare
f474bf8
to
d38db1e
Compare
d38db1e
to
1856d0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop the submodule updates and rebase
done @vaxerski please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wiki mr needed
done @vaxerski please review |
Describe your PR, what does it fix/add?
ref #8411
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
for code style, not sure if we prefer
PGAPSOUT->left
orPGAPSOUT.left
does not fix the issue with snap that @sand4rt mentioned, i might make another PR for that
Is it ready for merging, or does it need work?
ready