Skip to content

keybinds: movewindow respect gaps out for floating windows #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 3, 2025

Conversation

littleblack111
Copy link
Contributor

@littleblack111 littleblack111 commented Feb 7, 2025

Describe your PR, what does it fix/add?

ref #8411

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

for code style, not sure if we prefer PGAPSOUT->left or PGAPSOUT.left
does not fix the issue with snap that @sand4rt mentioned, i might make another PR for that

Is it ready for merging, or does it need work?

ready

@vaxerski
Copy link
Member

vaxerski commented Feb 9, 2025

why should it though

@littleblack111
Copy link
Contributor Author

is that not what gaps_out is supposed to do?
shall i add a config for it then

@LemmusLemmus
Copy link

LemmusLemmus commented Feb 9, 2025

I also agree that movewindow should respect gaps! But I would prefer if it looked at a separate config option, since I personally prefer no gaps for tiling windows (but I do like gaps for floating windows).

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the submodule updates and rebase

@littleblack111
Copy link
Contributor Author

done @vaxerski please review

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wiki mr needed

@littleblack111
Copy link
Contributor Author

done @vaxerski please review

@vaxerski vaxerski merged commit b5c0d0b into hyprwm:main Jun 3, 2025
12 checks passed
littleblack111 added a commit to littleblack111/Hyprland that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants