drm: reduce duplicated code in render creation#247
Merged
Conversation
initMgpu already does build gl formats so remove the temp creation of allocator and renderer in onReady() that only built glformats, also if guard the creation of renderers and allocators to make it less likely to recreate one that is already existing.
vaxerski
approved these changes
Feb 19, 2026
Moerliy
added a commit
to Moerliy/aquamarine
that referenced
this pull request
Apr 4, 2026
This reverts commit ed26bdb.
vaxerski
added a commit
that referenced
this pull request
Apr 4, 2026
Contributor
|
Any idea why this breaks apple? |
Contributor
Author
no clue dont have an apple device and all the time it breaks its just been blind attempts with people testing what works or not. and honestly the asahi drivers are simply broken by design. i mean why follow the 3 main gpu drivers/vendors (or well more we have plenty of mesa drivers, even software ones) when we can completly just go out of line and make rendernodes not easily associable with the displaynode. |
Member
|
idk apparently the asahi devs said that it's a hardware limitation on basically anything but amd/intel/nvidia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initMgpu already does build gl formats so remove the temp creation of allocator and renderer in onReady() that only built glformats, also if guard the creation of renderers and allocators to make it less likely to recreate one that is already existing.