Split input and output buffer attachments#249
Merged
Conversation
|
This seems to be working for me on my mGPU setup! |
|
I also saw the intended behavior building to your fork. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #246 and cleans up the code in general. I haven't tested on an mGPU setup yet, @dtgagnon could you test and make sure this fixes the issue for you?
Previously the buffer attachment had two halves combined in one which was causing issues. Splitting them out simplifies everything and fixes the issues. I've also converted the buffer destroy signal handler into a simple destructor for the attachments, which lets me simplify the if statements for getting rid of the old attachments as cleanup is now implicit (adding the new attachment evicts the old one and destructs it).