minor fixes #90
Open
minor fixes #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test the query only once instead of twice.
find returns npos, use it for comparision instead of !ends
ensure valid whitespaces doesnt end up causing it as a missed entry, and match exact keys.
vaxerski
reviewed
Dec 7, 2025
|
|
||
| begins = DATA.find('=', begins); | ||
| // trim leading whitespace | ||
| val.erase(val.begin(), std::ranges::find_if(val, [](auto c) { return !std::isspace(c); })); |
|
|
||
| if (begins == std::string::npos) | ||
| begins = DATA.find("\n" + std::string{what} + "="); | ||
| if (line.size() <= key.size() || line[key.size()] != '=') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only test the query for contain once, trim leading/traling whitespaces in extract and match exact keys to not skip valid entries where eg "Name = firefox " would appear in .desktop file.