Skip to content

Handle energy spread units in source generation - #472

Merged
Atraxus merged 1 commit into
hz-b:masterfrom
Atraxus:fix/energy-spread-unit-sources
Jul 6, 2026
Merged

Handle energy spread units in source generation#472
Atraxus merged 1 commit into
hz-b:masterfrom
Atraxus:fix/energy-spread-unit-sources

Conversation

@Atraxus

@Atraxus Atraxus commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Type of Change

  • Bug fix (non breaking change, fixing an issue)
  • New feature
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Documentation / Wiki update

Description

Correct parsing of the energy spread unit. It was not implemented before but the behavior for users is very confusing so I'll classify this as a bugfix.

Fixed #470

Optional notes for reviewer:


✅ Pre-Merge Checklist

Important

By requesting a review, you confirm this PR is complete from your side. Once approved, it may be merged by someone else. Both developers and reviewers must ensure the PR is truly ready for merge when all checks are green.

Please complete each item before requesting a review.

  • Code follows the project's coding standards
  • Unit tests for new functionality are added and pass
  • All existing tests pass
  • Resolved TODO Comments (prefer new issues instead)
  • Documentation, if applicable, including:
    • Doxygen comments for any new rayx-core API functions
    • Helpful inline comments where needed for clarity
    • Wiki pages, e.g. updated build instructions, new Element etc.
  • Commits:
    • Use clear and readable commit messages (e.g. Conventional commits)
    • Squash and rebase onto master if individual commits don’t add value
    • Ensure linear commit history (required by master)

@Atraxus
Atraxus force-pushed the fix/energy-spread-unit-sources branch from b01591e to f8a04a6 Compare June 24, 2026 06:46
@Atraxus
Atraxus marked this pull request as ready for review June 24, 2026 08:26

@MMXLVIII MMXLVIII left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, can merge afterwards

Comment thread Intern/rayx-core/src/Rml/DesignSourceWriter.h
Comment thread Intern/rayx-core/tests/testSources.cpp
@Atraxus
Atraxus force-pushed the fix/energy-spread-unit-sources branch from f8a04a6 to 94e73e0 Compare July 2, 2026 14:23
@Atraxus
Atraxus merged commit 3af6e2e into hz-b:master Jul 6, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title: energySpreadUnit in RML is ignored for energy sampling

2 participants