Open
Conversation
The modofications solve two problems regarding issues hzeller#198 and hzeller#202: hzeller#198: modifications in my_bus_callback ensure that after the last URI is played gstreamer is REALLY stopped and that the URI is cleared. modifications in output_gstreamer_play ensure, that no empty URIs are passed to the gstreamer, which leads to problems with bluealsa hzeller#202: prepare_next_stream as answer to "about-to-finish" is no longer used for setting the next URI. This ensures, that only the bus-cb sets the next URI and gstreamer is stopped and started again, which is needed to ensure propper playing of MP3 with different sampling rates.
mchalain
added a commit
to mchalain/gmrender-resurrect
that referenced
this pull request
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modofications solve two problems regarding issues #198 and #202:
#198: modifications in my_bus_callback ensure that after the last URI is played gstreamer is REALLY stopped and that the URI is cleared. modifications in output_gstreamer_play ensure, that no empty URIs are passed to the gstreamer, which leads to problems with bluealsa
#202: prepare_next_stream as answer to "about-to-finish" is no longer used for setting the next URI. This ensures, that only the bus-cb sets the next URI and gstreamer is stopped and started again, which is needed to ensure propper playing of MP3 with different sampling rates.