Update Data Setup Page 1B in line with design updates#1275
Draft
ekin-odabas wants to merge 17 commits into
Draft
Update Data Setup Page 1B in line with design updates#1275ekin-odabas wants to merge 17 commits into
ekin-odabas wants to merge 17 commits into
Conversation
added 15 commits
April 1, 2026 13:57
…sistence into localStorage
added 2 commits
April 14, 2026 15:35
| <svg | ||
| class="fill-neutral-500" | ||
| height="1rem" | ||
| role="img" |
Contributor
There was a problem hiding this comment.
For all the SVGs: If they don't have alt text then you're better off removing role="img" and adding aria-hidden="true". The DfE example announces an image for screen-readers but has no accessible text to accompany it. It doesn't need accessible text because of the "DfE" text, but that's not associated with the image.
| ariaControls={`${item.id}-details`} | ||
| ariaLabel={`Show/Hide ${item.id}-details`} | ||
| > | ||
| <span class="-ml-2 text-nowrap text-secondary hover:underline"> |
Contributor
There was a problem hiding this comment.
KevinEtchells
requested changes
Apr 14, 2026
Contributor
KevinEtchells
left a comment
KevinEtchells
left a comment
There was a problem hiding this comment.
This looks great, and the stories page makes reviewing this a really nice process!
Just a couple of things to address around SVG attributes and colour contrast. Other than that it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Data setup page 1b implementation needs to be updated in line with the latest design.
Changes proposed in this pull request
This PR implements the new design.
Guidance to review
View component in stories.
Things to check
.env.testfiles in the repo