[Aikido] Fix security issue in urllib3 via minor version upgrade from 2.2.3 to 2.6.3#15
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade urllib3 to address critical security vulnerabilities involving decompression bombs, resource exhaustion, and potential redirect-based attacks.
✅ Code not affected by breaking changes.
No breaking changes from the urllib3 upgrade affect this codebase.
The codebase does not directly depend on urllib3 (it's not listed in
pyproject.tomldependencies), and my searches found no usage of:HTTPResponse.getheaders()orHTTPResponse.getheader()methodsContentDecodercustom implementationsDirect urllib3 imports or HTTPResponse object handling
Additionally, the project requires Python >=3.12 (as specified in
pyproject.toml), so the removal of Python 3.8 support in urllib3 2.3.0 is not a concern.While urllib3 may be a transitive dependency through packages like
cookiecutter, this codebase does not directly interact with urllib3's API, making it immune to the breaking changes in version 2.6.3.All breaking changes by upgrading urllib3 from version 2.2.3 to 2.6.3 (CHANGELOG)
HTTPResponse.getheaders()method in favor ofHTTPResponse.headers. Removed theHTTPResponse.getheader(name, default)method in favor ofHTTPResponse.headers.get(name, default).urllib3.response.ContentDecoder.✅ 5 CVEs resolved by this upgrade
This PR will resolve the following CVEs: