[Aikido] Fix 6 security issues in urllib3, requests#16
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
[Aikido] Fix 6 security issues in urllib3, requests#16aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade urllib3 and requests to fix decompression bomb DoS vulnerabilities, SSRF bypass, and redirect control issues.
✅ Code not affected by breaking changes.
No breaking changes from the urllib3 (2.2.3 => 2.6.3) or requests (2.32.3 => 2.33.0) upgrades affect this codebase.
The codebase:
Does not import or use
urllib3orrequestsdirectlyDoes not use the removed
HTTPResponse.getheaders()orHTTPResponse.getheader()methodsDoes not implement custom
ContentDecoderclassesRequires Python >=3.12 (as specified in
pyproject.toml), which is well above the dropped support for Python 3.8 (urllib3) and Python 3.9 (requests)All breaking changes are irrelevant to this codebase.
All breaking changes by upgrading urllib3 from version 2.2.3 to 2.6.3 (CHANGELOG)
HTTPResponse.getheaders()method in favor ofHTTPResponse.headers. Removed theHTTPResponse.getheader(name, default)method in favor ofHTTPResponse.headers.get(name, default).urllib3.response.ContentDecoder.All breaking changes by upgrading requests from version 2.32.3 to 2.33.0 (CHANGELOG)
✅ 6 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
extract_zipped_paths()utility function allows local attackers to pre-create malicious files in the temp directory that would be loaded instead of legitimate ones, enabling arbitrary code execution.