[Aikido] Fix 11 security issues in gitpython, urllib3, requests and 1 more#18
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
[Aikido] Fix 11 security issues in gitpython, urllib3, requests and 1 more#18aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
Author
|
Closed by Aikido: a new AutoFix has been created → #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade GitPython, urllib3, requests, and pygments to fix critical RCE vulnerabilities via unsafe Git option bypass, config injection, reference path traversal, and decompression DoS attacks.
✅ After thorough analysis of the codebase, none of the breaking changes in the package upgrades affect this codebase:
Python version compatibility: The project requires Python >=3.12 (as specified in
pyproject.toml), which is well above the minimum versions required by the upgraded packages (urllib3 requires 3.9+, requests requires 3.10+, pygments requires 3.9+).urllib3 changes: No usage of
HTTPResponse.getheaders(),HTTPResponse.getheader(),ContentDecoder, or chained Content-Encoding values found in the codebase.gitpython changes:
The security fixes in 3.1.47-3.1.49 target unsafe underscored kwargs (parameters starting with
_), control characters in config values, and out-of-repo reference access.The codebase uses standard GitPython parameters like
working_tree=Trueinrepo.head.reset()calls (cruft/_commands/utils/generate.py:40andtests/test_api.py:106), which are legitimate parameters, not unsafe underscored kwargs.The
filter="blob:none"andno_checkout=Trueparameters passed toRepo.clone_from()incruft/_commands/check.py:23-24are standard snake_case parameters, not underscored kwargs that would be blocked.No git configuration manipulation or reference manipulation outside of repo boundaries detected.
All breaking changes are related to features not used by this codebase.
All breaking changes by upgrading requests from version 2.32.3 to 2.33.1 (CHANGELOG)
All breaking changes by upgrading pygments from version 2.18.0 to 2.20.0 (CHANGELOG)
✅ 11 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
upload_pack) instead of hyphens, which are normalized to dangerous Git flags after the safety check, enabling arbitrary command execution. This affectsRepo.clone_from(),Remote.fetch(),Remote.pull(), andRemote.push()when processing attacker-controlled kwargs.multi_optionsinclone()occurs before string splitting, allowing attackers to embed unsafe git config options (like--config core.hooksPath=) within safe-looking strings to bypass checks and achieve remote code execution during clone operations.set_value()fails to validate newlines in config values, allowing attackers to inject Git config sections (e.g.,[core]with malicioushooksPath). This enables arbitrary code execution when Git operations invoke hooks, particularly dangerous when user-supplied inputs like author names reachset_value()without sanitization.extract_zipped_paths()utility function uses predictable filenames when extracting zip archives to the temp directory, allowing local attackers to pre-create malicious files that get loaded instead of legitimate ones, resulting in arbitrary code execution.