[Aikido] Fix 13 security issues in gitpython, urllib3, requests and 1 more#20
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
[Aikido] Fix 13 security issues in gitpython, urllib3, requests and 1 more#20aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
Author
|
Closed by Aikido: a new AutoFix has been created → #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade GitPython, urllib3, requests, and Pygments to fix critical RCE vulnerabilities via Git hook injection and command execution bypasses. This update includes breaking changes that require manual migration.
gitpython (3.1.43 => 3.1.50) - Unsafe underscored git kwargs blocked
Where your code is affected:
cruft/_commands/check.pylines 21-26Impact: The code passes
filter="blob:none"andno_checkout=Trueas kwargs toget_cookiecutter_repo(), which forwards them toRepo.clone_from(). GitPython 3.1.47+ blocks underscored git kwargs likeno_checkoutfor security reasons (GHSA-rpm5-65cw-6hj4). This will cause thecheckcommand to fail with an error about unsafe parameters.Remediation: Replace underscored kwargs with their non-underscored equivalents or use the appropriate GitPython API methods that don't rely on passing raw git options with underscores.
Note: The project requires Python >=3.12 (as specified in
pyproject.toml), so the Python version drops in urllib3 (3.8), requests (3.9), and pygments (3.8) do not affect this codebase. Additionally, urllib3 is not directly imported, and requests/pygments are not used in the codebase at all.All breaking changes by upgrading gitpython from version 3.1.43 to 3.1.50 (CHANGELOG)
shlex, and unsafe underscored git kwargs are blockedAll breaking changes by upgrading urllib3 from version 2.2.3 to 2.7.0 (CHANGELOG)
HTTPResponse.getheaders()method in favor ofHTTPResponse.headers. Removed theHTTPResponse.getheader(name, default)method in favor ofHTTPResponse.headers.get(name, default).urllib3.response.ContentDecoder.All breaking changes by upgrading pygments from version 2.18.0 to 2.20.0 (CHANGELOG)
✅ 13 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
extract_zipped_paths()utility function uses predictable filenames when extracting zip archives to the temp directory, allowing local attackers to pre-create malicious files that get loaded instead of legitimate ones, resulting in arbitrary code execution.