feat: remove ray Queues, add worker healthcheck#21
Merged
Conversation
aydin-utting
commented
Nov 11, 2025
aydin-utting
commented
Collaborator
- Removed ray queues, actors now check SQS directly
- added a second sqs queue for LLM tasks
- Added a container healthcheck to the worker, which checks if any of the actors have not updated a file within the last 20 minutes. This uses fastapi as an healthcheck endpoint.
* Removed ray queues, actors now check SQS directly * added a second sqs queue for LLM tasks * Added a container healthcheck to the worker, which checks if any of the actors have not updated a file within the last 20 minutes. This uses fastapi as an healthcheck endpoint.
aydin-utting
force-pushed
the
refactor/remove-ray-queues
branch
from
28b7571 to
6cf2ab0
Compare
RichJackson
approved these changes
Nov 11, 2025
RichJackson
left a comment
RichJackson
left a comment
Contributor
There was a problem hiding this comment.
looks good. Couple of minor comments
|
|
||
|
|
||
| def get_queue_service(storage_service_name: str) -> QueueService: | ||
| def get_queue_service(storage_service_name: str, queue_name: str, deadletter_queue_name: str) -> QueueService: |
Contributor
There was a problem hiding this comment.
cheeky - because you didn't change this, but should storage_service_name be called queue_service_class_name or something?
Collaborator
Author
There was a problem hiding this comment.
yes I'll update
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| async def queue_service(): |
Contributor
There was a problem hiding this comment.
don't we want to purge the queue between tests?
Collaborator
Author
There was a problem hiding this comment.
oh I didn't know that that was what this was for, I saw it wasn't used as a fixture anywhere and removed it. I'll re-add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.