Skip to content

Fix OpenAI structured chat response handling#60

Open
Kevin-Li-2025 wants to merge 1 commit into
i-dot-ai:mainfrom
Kevin-Li-2025:fix-openai-structured-chat-response
Open

Fix OpenAI structured chat response handling#60
Kevin-Li-2025 wants to merge 1 commit into
i-dot-ai:mainfrom
Kevin-Li-2025:fix-openai-structured-chat-response

Conversation

@Kevin-Li-2025

Copy link
Copy Markdown

Summary

  • replace the undefined handle_response call in OpenAIModelAdapter.structured_chat with the existing response handling pattern used by chat
  • add a focused unit test that uses a fake Azure client and does not require live credentials

Fixes #36.

Validation

  • uv run --python 3.12 --with pytest --with pytest-asyncio --with pydantic --with pydantic-settings --with python-dotenv --with i-dot-ai-utilities --with openai --with google-genai pytest tests/test_azure_openai_adapter.py -q
  • uv run --python 3.12 --with ruff ruff check common/llm/adapters/azure_openai.py tests/test_azure_openai_adapter.py
  • uv run --python 3.12 --with pydantic --with pydantic-settings --with python-dotenv --with i-dot-ai-utilities --with openai --with google-genai python -m py_compile common/llm/adapters/azure_openai.py tests/test_azure_openai_adapter.py

@Kevin-Li-2025 Kevin-Li-2025 requested a review from a team as a code owner June 27, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAIModelAdapter.structured_chat calls undefined handle_response method

1 participant