Skip to content

Fresh 2 support#98

Merged
adrai merged 6 commits intoi18next:masterfrom
ggodet-bar:fresh-2-support
Dec 6, 2025
Merged

Fresh 2 support#98
adrai merged 6 commits intoi18next:masterfrom
ggodet-bar:fresh-2-support

Conversation

@ggodet-bar
Copy link
Contributor

This PR adds a freshPlugin that acts as a middleware for detecting languages and applying translations, in the context of the Fresh 2.x framework.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@socket-security
Copy link

socket-security bot commented Nov 27, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​opentelemetry/​api@​1.9.010010010082100
Addedpreact-render-to-string@​6.6.310010010090100
Addedpreact@​10.27.210010010091100
Added@​preact/​signals@​2.5.110010010096100

View full report

"@babel/core": "7.26.0",
"@babel/preset-env": "7.26.0",
"@hapi/hapi": "^21.3.12",
"@opentelemetry/api": "^1.9.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are all these new dependencies necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fresh2 core relies by default on these dependencies. This is the minimal set that enables loading the fresh2 App class in the tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you added fresh for Deno... so there should not be any dependency in the package.json...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh I see....

@adrai
Copy link
Member

adrai commented Nov 28, 2025

btw: what's about these other tests?

addRoute.fresh.js
getResourcesHandler.fresh.js
missingKeyHandler.fresh.js

@adrai adrai merged commit b3c67d7 into i18next:master Dec 6, 2025
6 checks passed
@adrai
Copy link
Member

adrai commented Dec 6, 2025

included in v3.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants