feat: use const type parameters for useTranslation() #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Apr 22, 2025
Depends on i18next/react-i18next#1842 Signed-off-by: Simon Ser <[email protected]>
|
@marcalexiei ok for you? |
marcalexiei
reviewed
Apr 23, 2025
TypeScript 5.0 has introduced const type parameters [1]. These indicate that a more specific type is preferred over a more general one. As a result, the resulting UseTranslationResponse will be more precise and retain the passed-in namespace and prefix. This can be used by extractors and other tooling to find out exactly which key is accessed by a translation function call. [1]: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#const-type-parameters
emersion
force-pushed
the
use-translation-const-type-params
branch
from
9dc4de3 to
2a0bd3b
Compare
|
Makes sense to me, done! |
|
Thanks for the speedy review! |
|
thanks both of you... |
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Apr 23, 2025
We want to grab i18next/react-i18next#1842 Signed-off-by: Simon Ser <[email protected]>
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Apr 24, 2025
We want to grab i18next/react-i18next#1842 Signed-off-by: Simon Ser <[email protected]>
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Apr 24, 2025
We want to grab i18next/react-i18next#1842 Signed-off-by: Simon Ser <[email protected]>
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Apr 29, 2025
We want to grab i18next/react-i18next#1842 Signed-off-by: Simon Ser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 5.0 has introduced const type parameters. These indicate that a more specific type is preferred over a more general one. As a result, the resulting UseTranslationResponse will be more precise and retain the passed-in namespace and prefix. This can be used by extractors and other tooling to find out exactly which key is accessed by a translation function call.
Checklist
npm run test