Skip to content

Conversation

@anawas
Copy link
Collaborator

@anawas anawas commented Jan 5, 2026

Summary

This PR fixes issue #669. The script test.yml now installs the MPI framework on the system itself instead of using the version from conda.

Changes

To file test.yaml:

  • New step Install system MPICH (needed for external mpich) + compat symlink for wsclean with
    • Install the MPICH package on the runner (sudo apt-get install -y mpich libmpich-dev libmpich12)
    • Create symbolic link libmpichcxx.so.12 --> libmpicxx.so.12 in order for wsclean to find the library.
  • Update step Install Deps with some debug output. May be helpful if the error persists

To file environment.yml:

  • Pinned versions of mpi4py, mpich and ucx because these versions work for this workflow.

@anawas anawas requested a review from Lukas113 January 5, 2026 15:04
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.05%. Comparing base (ff1aa1c) to head (83343ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   71.05%   71.05%           
=======================================
  Files          56       56           
  Lines        5815     5815           
=======================================
  Hits         4132     4132           
  Misses       1683     1683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lukas113
Copy link
Collaborator

Lukas113 commented Jan 5, 2026

looks hacky, but if it just works this way 👍

just one question: what's the reason for pinning mpi4py? As you may know, I'm not a fan of pinning deps if it can be avoided 😉

@anawas
Copy link
Collaborator Author

anawas commented Jan 6, 2026

I agree - usually. The pinned version is a good compromise between the current version and a version that works for everything. I get the impression that the whole build process is very fragile. That's why I want to “hammer in as many nails as possible” to keep the whole thing together.

@anawas
Copy link
Collaborator Author

anawas commented Jan 12, 2026

I'll try another solution without pinning mpi4py. This indeed may not be necessary.

@anawas
Copy link
Collaborator Author

anawas commented Jan 13, 2026

Done. Pinning the mpi versions is not necessary. However, you still need to install the mpich packages locally on the server, and you cannot use those provided by conda.
I ask to approve this PR. This allows the tests to be run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants