-
Notifications
You must be signed in to change notification settings - Fork 9
Update test workflow #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update test workflow #675
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 71.05% 71.05%
=======================================
Files 56 56
Lines 5815 5815
=======================================
Hits 4132 4132
Misses 1683 1683 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks hacky, but if it just works this way 👍 just one question: what's the reason for pinning |
|
I agree - usually. The pinned version is a good compromise between the current version and a version that works for everything. I get the impression that the whole build process is very fragile. That's why I want to “hammer in as many nails as possible” to keep the whole thing together. |
|
I'll try another solution without pinning |
|
Done. Pinning the mpi versions is not necessary. However, you still need to install the mpich packages locally on the server, and you cannot use those provided by conda. |
Summary
This PR fixes issue #669. The script
test.ymlnow installs the MPI framework on the system itself instead of using the version from conda.Changes
To file test.yaml:
sudo apt-get install -y mpich libmpich-dev libmpich12)libmpichcxx.so.12-->libmpicxx.so.12in order for wsclean to find the library.To file environment.yml:
mpi4py,mpichanducxbecause these versions work for this workflow.