Open
Conversation
tezena
requested changes
Feb 17, 2026
tezena
left a comment
tezena
left a comment
There was a problem hiding this comment.
I think you should remove the checker that verifies whether a pattern already has a surprisingness score. Since we have abstract patterns, and already exists in the space, it will bind with the rest of the patterns. As a result, no new surprisingness scoring will be applied afterward.
Collaborator
Author
|
the changes have been added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an nary implemetation for IIsurp, where regradless of where the 'concept' is placed in the pattern as a result of how the kb was structured, it will consider every symbol metatype within the pattern as a potential symbol and tries to find super concept couterparts for it by substituting it with a variable within the original pattern and collecting all the bindings for that variable and checks if any of those bindings are valid super concepts to the symbol metatype we had replaced with a variable.
It does this for every subpattern within the conjunct and aggregates the max and min probabilities for it , which will finally be concatnated with the estimates geneated by consdering the partitions of the conjunct and finds how much the emperical probability of the conjunct deviates from the max and min estimates.