Added test-cases for isurp and isurp-old#156
Open
yonayetol wants to merge 3 commits intoiCog-Labs-Dev:genericfrom
Open
Added test-cases for isurp and isurp-old#156yonayetol wants to merge 3 commits intoiCog-Labs-Dev:genericfrom
yonayetol wants to merge 3 commits intoiCog-Labs-Dev:genericfrom
Conversation
yonayetol
changed the title
tezena
requested changes
Feb 17, 2026
tezena
left a comment
tezena
left a comment
There was a problem hiding this comment.
we need to test , the chainner based surp components also. Including jsd .
- Introduced a new variable $topOfNewHead to capture the top element of $new_head. - Replaced the previous emp_value computation with a conditional evaluation using eval. - The new logic checks if $topOfNewHead is an expression and adjusts the emp_value calculation accordingly. - Commented out the old emp_value logic for clarity and future reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new test cases to both
test-isurp-old.mettaandtest-isurp.mettato verify the behavior of theisurp-oldandisurpfunctions using n-ary format patterns and a dedicated n-ary dataset. The tests cover both normalized and non-normalized scenarios, as well as different parameter configurations.Tests for n-ary format patterns:
Added import of the
dataset_for_n_arry_formatn-ary dataset in bothtest-isurp-old.mettaandtest-isurp.mettafor use in new test cases. [1] [2]Added multiple assertions to
test-isurp-old.mettafor theisurp-oldfunction, testing conjunctive patterns with normalization enabled and disabled, using the n-ary dataset.Added multiple assertions to
test-isurp.mettafor theisurpfunction, testing conjunctive patterns with normalization enabled and disabled, and a ratio parameter, using the n-ary dataset.