Skip to content

Comments

CI workflow#202

Open
Ephrame-A wants to merge 2 commits intomainfrom
eph/actions
Open

CI workflow#202
Ephrame-A wants to merge 2 commits intomainfrom
eph/actions

Conversation

@Ephrame-A
Copy link
Contributor

This pull request introduces significant improvements to the CI workflow, test infrastructure, and test suite for the project. The main changes include enhancing the GitHub Actions workflow to support the PeTTa version of the code.

CI/CD and Environment Setup:

  • Enhanced the .github/workflows/MeTTa-CI.yml workflow to:
    • Check out both the metta-attention and PeTTa repositories, ensuring all dependencies are available.
    • Install and verify the required version of SWI-Prolog, and fix line endings in the PeTTa repository for compatibility.
    • Update Python dependency installation to use a requirements file and adjust the test execution path to run tests from within the PeTTa directory.

Test Runner Improvements:

  • Major overhaul of scripts/run-tests.py:
    • Improved test discovery to exclude specific tests (e.g., ForgettingAgent), and enhanced output formatting with colored section headers.
    • Made test execution more robust by isolating the environment, handling process management, and improving failure detection (including assertion mismatches and error emoji detection).
    • Switched to running tests via sh run.sh for better cross-platform compatibility and to match the expected environment.
    • Enhanced summary reporting and error handling for greater clarity and reliability. [1] [2]

Test Suite Modernization:

  • Updated test assertions in multiple .metta test files to use subtraction-atom for comparing atom sets, making the tests more robust to ordering and improving clarity of test intent. [1] [2] [3] [4]
  • Adjusted sleep durations in tests for timing reliability.

Imports and Path Fixes:

  • Updated import paths in various test files to reflect the new repository structure and ensure compatibility with the new CI setup. This includes adding missing imports (e.g., lib_spaces) and correcting relative paths for utility modules. [1] [2] [3] [4] [5]

i have checked the pipeline in my fork here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant