Fixes on feature selection (incremental & smd)#441
Merged
Conversation
… caching integrated
Yagth
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a significant refactor and optimization of the Incremental Feature Selection (IFS) module, addressing critical numerical bugs, and performance bottlenecks found in the previous implementation.
Description
Motivation and Context
Optimization and bug fix.
How Has This Been Tested?
Tested locally and awaits more tests i
Enhanced Testing & Integration
Created tests/incremental-feature-selection-test.metta with comprehensive validation across
Parity,Majority, andMuxdata sets.Successfully integrated the new logic into the representation module and verified it with updated integration tests in
representation-test.metta.Utility Updates: Patched
smd.mettaand other helpers to resolve function name conflicts (e.g., updating first to first-from-pair).Cache Management
LRU Policy: The cache includes a monotonic clock and automatic eviction of the oldest entries when reaching capacity (default 128).
One quirk here is for test case with different tables, cache needs to be cleared after use with a data table so that cache for that table cannot be used for the next one.
Next Steps
Use the entropy and MI calculation for other selection algorithms as well.
Find a general caching implementation to be used for other expensive procedures as well without needing to store big data table as part of the key.
Checklist: