Optimization of Stochastic Maximum Dependency Feature Selection#443
Merged
Conversation
…els, integrated this into the main feature selector and added test cases to cover the changes
…flow compatibility, replaced `get-nth` with `List.getByIdx`
Yagth
reviewed
May 8, 2026
Yagth
requested changes
May 8, 2026
Yagth
left a comment
Member
There was a problem hiding this comment.
I will merge this after you address the import comment.
Yagth
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Stochastic Maximum Dependency (SMD) algorithm and integrates it into the main feature selection dispatcher, improving overall performance in PeTTa environment.
Description
Refactored the SMD feature selection algorithm to use PeTTa's native
conslist data structure. Integratedcached-mi-scoreacross the selection process.Refined the
featureSelectionentry point infeature-selection-main.metta. The SMD branch now directly calls the optimized implementation, removing legacy manual calculations and ensuring a clean flow for both empty and pre-populated initial feature sets.Motivation and Context
PeTTa optimizing of the existing code base.
How Has This Been Tested?
Updated tests/smd-test.metta with comprehensive benchmarks for
mux6andmajority5data sets.Added a specific test case confirming that forced features (e.g., (0 2)) are correctly present in every resulting feature set.
TO DO
For cleaner code, move all the refactored feature selection specific helpers to a separate file,
feature-selection-helpers.metta.Types of changes
Checklist: