Skip to content

Optimization of Stochastic Maximum Dependency Feature Selection#443

Merged
Yagth merged 6 commits into
iCog-Labs-Dev:devfrom
K1rubel:dev
May 8, 2026
Merged

Optimization of Stochastic Maximum Dependency Feature Selection#443
Yagth merged 6 commits into
iCog-Labs-Dev:devfrom
K1rubel:dev

Conversation

@K1rubel

@K1rubel K1rubel commented May 6, 2026

Copy link
Copy Markdown
Contributor

This PR refactors the Stochastic Maximum Dependency (SMD) algorithm and integrates it into the main feature selection dispatcher, improving overall performance in PeTTa environment.

Description

Refactored the SMD feature selection algorithm to use PeTTa's native cons list data structure. Integrated cached-mi-score across the selection process.
Refined the featureSelection entry point in feature-selection-main.metta. The SMD branch now directly calls the optimized implementation, removing legacy manual calculations and ensuring a clean flow for both empty and pre-populated initial feature sets.

Motivation and Context

PeTTa optimizing of the existing code base.

How Has This Been Tested?

Updated tests/smd-test.metta with comprehensive benchmarks for mux6 and majority5 data sets.
Added a specific test case confirming that forced features (e.g., (0 2)) are correctly present in every resulting feature set.

TO DO

For cleaner code, move all the refactored feature selection specific helpers to a separate file, feature-selection-helpers.metta.

Types of changes

  • Optimized implementation.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@K1rubel K1rubel changed the title Optimization of Stochastic Feature Selection Optimization of Stochastic Maximum Dependency Feature Selection May 6, 2026
Comment thread feature-selection/stochasitc-maximum-dependency.metta

@Yagth Yagth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this after you address the import comment.

@Yagth Yagth merged commit 212cf5f into iCog-Labs-Dev:dev May 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants