Fix SITL binary path resolution for dev and packaged modes #2498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SITL feature was broken because the code looked for binaries in the wrong location. The path used __dirname which points to the Vite build output (.vite/build/), but SITL binaries are in resources/public/sitl/. Changes: - Add getSitlBasePath() function that returns correct path based on whether app is packaged (process.resourcesPath) or in dev mode (app.getAppPath()/resources/public/sitl) - Add extraResource in forge.config.js to include SITL in packages - Add afterCopy hook to remove binaries for other platforms/architectures, reducing package size
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SITL feature which was broken because the code looked for binaries in the wrong location.
Problem
The SITL path used __dirname which points to the Vite build output (.vite/build/), but SITL binaries are located in resources/public/sitl/. This meant SITL couldn't find its executables in either dev mode or packaged builds.
Changes
Add getSitlBasePath() function that returns the correct path based on whether the app is packaged (process.resourcesPath) or in dev mode (app.getAppPath()/resources/public/sitl)
Add extraResource in forge.config.js to include SITL binaries in packaged builds