Fix decompiler to output whenChanged() instead of delta() #2504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sensei-hacker
force-pushed
the
fix-decompiler-whenchanged-naming
branch
2 times, most recently
from
e27a8d7 to
a4c2280
Compare
- Decompiler now outputs whenChanged() to match the API definition - Use OPERAND_TYPE.LC from constants instead of hardcoded value - Add test for whenChanged() decompilation - Add test for OPERAND_TYPE.LC usage in handleNot()
sensei-hacker
force-pushed
the
fix-decompiler-whenchanged-naming
branch
from
a4c2280 to
83dd3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the JavaScript programming decompiler to output
whenChanged()instead ofdelta().Changes
whenChangedpattern now renders aswhenChanged()to match the APIOPERAND_TYPEfrom constants instead of hardcoding the valueWhy
The API defines
whenChanged(value, threshold, callback)as the user-facing function, but the decompiler was outputtingdelta(). This caused round-trip inconsistency - code compiled withwhenChanged()would decompile todelta().