Skip to content

Conversation

@funkill
Copy link
Contributor

@funkill funkill commented Dec 28, 2025

Updated ru translation (+ cosmetic fixes)

Added to available langs, added to dir structure (where found zh_CN l10n key)

@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Russian (ru) translation for the INAV Configurator application and adds Russian to the list of available languages. The changes include translation improvements, cosmetic fixes for consistency, and the addition of Russian locale support across the codebase.

  • Adds Russian ('ru') to the available languages list
  • Updates Russian translations with improved wording and cosmetic fixes to match English source formatting
  • Updates documentation to reflect the new Russian locale support

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
locale/ru/messages.json Updates and refines Russian translations, removes trailing periods for consistency with English source, reorganizes JavaScript programming related entries, but removes the javascriptOptimizationsApplied translation key
js/localization.js Adds 'ru' to the availableLanguages array in correct alphabetical order
CLAUDE.md Updates directory structure documentation to include 'ru' in the list of supported i18n translations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"language_de": {
"message": "Deutsch",
"_comment": "Don't translate!"
"_comment": "Don't translate!",
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both "_comment" and "comment" fields are present for this entry. Looking at the English translation file (locale/en/messages.json), the "language_de" entry only uses "comment" (without underscore), while other language entries use "_comment" (with underscore). This creates an inconsistency. The entry should use only one comment field to match the pattern established in the source language file - preferably "comment" without the underscore to match the English version of this same key.

Suggested change
"_comment": "Don't translate!",

Copilot uses AI. Check for mistakes.
@sensei-hacker sensei-hacker changed the base branch from master to maintenance-9.x December 29, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants