Simplification of the loading process for rasterized tiles and mesh tiles #2609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchoqueux
changed the title
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
13 times, most recently
from
489581c to
afdfc01
Compare
Contributor
Author
|
Rebased |
Contributor
Author
|
I’ve come up with a possible way to simplify this — what do you think of these changes? |
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
from
afdfc01 to
6f64fdf
Compare
Contributor
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
4 times, most recently
from
2cec783 to
15dfa04
Compare
Contributor
Author
|
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
4 times, most recently
from
c7b4635 to
4bd5c32
Compare
Contributor
Author
|
|
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
from
e9aab85 to
3d3be67
Compare
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
from
592d39a to
4bdf282
Compare
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
6 times, most recently
from
e175c90 to
ab558ea
Compare
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
3 times, most recently
from
eecc503 to
4c86123
Compare
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
from
4c86123 to
3d5de39
Compare
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
from
a55f702 to
5235375
Compare
gchoqueux
force-pushed
the
refacto/simple_loading_tile
branch
from
5235375 to
7a3ea9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a possible simplification of the loading process for rasterized tiles and mesh tiles.
Summary of changes
TileMeshinstances are now created directly inTiledGeometryLayer, without using commands or providers.TileMesh.pendingSubdivisionhas been removed.TiledGeometryLayer#hasEnoughTexturesToSubdividehas been removed.updateLayeredMaterialNodeImageryandupdateLayeredMaterialNodeElevationhave been merged into a single lightweight method.TileProviderhas been deleted.RasterTile#load.