fix: Custom example with custom projection #2656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftoromanoff
changed the title
ftoromanoff
force-pushed
the
fix/customView
branch
from
c41a6dd to
9784e75
Compare
ftoromanoff
force-pushed
the
fix/customView
branch
from
9784e75 to
0a69b15
Compare
ftoromanoff
force-pushed
the
fix/customView
branch
from
0a69b15 to
3a94625
Compare
ftoromanoff
force-pushed
the
fix/customView
branch
from
3a94625 to
4bf3817
Compare
jailln
previously approved these changes
Jan 8, 2026
jailln
reviewed
Jan 8, 2026
|
|
||
| childNode.voxelOBB.matrixWorldInverse = this.voxelOBB.matrixWorldInverse; | ||
| childNode.clampOBB.matrixWorldInverse = this.clampOBB.matrixWorldInverse; | ||
| this.clampOBB.parent!.add(childNode.clampOBB); |
Contributor
There was a problem hiding this comment.
what does the !. syntax means ? Do you mean ?. instead ? (there is other occurences in the MR)
Contributor
Author
There was a problem hiding this comment.
the !. is a TS syntax. it lmight be in a way similar to the ?. but on the type and not on the value.
In this case, I know that parent is always define even if parent on a generic clampOBB can be definied or not, as we call the createChildOBB, only on a child node (thus with a parent)
jailln
dismissed
their stale review
forgot one comment that must be addressed before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to the issue #2633.
A proposal to solve the problemethat appeared with the custom example
https://github.com/bloc-in-bloc/itowns/blob/f/custom-pointcloud-sample/examples/demo_hackathon_orvault_planarView.html
The custome transformation apply to the global object3d wasn't apply to the newly generated OBB, thus considering that they were elsewhere.