Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
57bec70
log signin retries
paulius-valiunas Sep 30, 2024
3d50ddc
remove crypto-browserify
paulius-valiunas Sep 30, 2024
abf0490
Change files
paulius-valiunas Sep 30, 2024
f303442
use corepack
paulius-valiunas Oct 1, 2024
e12d7d1
use corepack
paulius-valiunas Oct 1, 2024
96bcb26
fix audit
paulius-valiunas Oct 1, 2024
1fc85a4
Change files
paulius-valiunas Oct 1, 2024
46c9414
found latest working version of the types package
paulius-valiunas Oct 1, 2024
5f84c18
fix lint
paulius-valiunas Oct 1, 2024
ff518de
merge
paulius-valiunas Mar 18, 2025
7612b8c
Merge remote-tracking branch 'origin/main' into log-signin-retries
paulius-valiunas Mar 18, 2025
09e287c
fix lock file
paulius-valiunas Mar 18, 2025
9c882db
fix merge
paulius-valiunas Mar 18, 2025
da654d9
undo node update
paulius-valiunas Mar 18, 2025
675e86c
fix corepack?
paulius-valiunas Mar 18, 2025
d5cac74
eh?
paulius-valiunas Mar 18, 2025
c1e5192
update node
paulius-valiunas Mar 18, 2025
1bdec70
update corepack?
paulius-valiunas Mar 18, 2025
9025365
(ㆆ_ㆆ)
paulius-valiunas Mar 18, 2025
b8304d2
update pnpm?
paulius-valiunas Mar 18, 2025
ac37ec8
print corepack version
paulius-valiunas Mar 19, 2025
7270bdf
force latest version of corepack
paulius-valiunas Mar 19, 2025
99698ae
expand version range
paulius-valiunas Mar 19, 2025
0d3be44
Merge remote-tracking branch 'origin/main' into log-signin-retries
paulius-valiunas Apr 2, 2025
d6a9eef
Merge remote-tracking branch 'origin/main' into log-signin-retries
paulius-valiunas Jun 17, 2025
b66daa7
pnpm up
paulius-valiunas Jun 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@
"eslint.format.enable": true,
"eslint.lintTask.enable": true,
"editor.codeActionsOnSave": {
"source.fixAll.markdownlint": true, // first run the markdown linter
"editor.action.fixAll": true, // Run the default formatter before eslint, it handles whitespace better
"source.fixAll.eslint": true // then run ESLint auto-fix
"source.fixAll.markdownlint": "explicit",
"editor.action.fixAll": "explicit",
"source.fixAll.eslint": "explicit"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "log signin retries",
"packageName": "@itwin/oidc-signin-tool",
"email": "66480813+paulius-valiunas@users.noreply.github.com",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@
"beachball": "^2.43.1",
"lage": "^2.7.18",
"process": "^0.11.10"
}
},
"packageManager": "pnpm@9.11.0+sha512.0a203ffaed5a3f63242cd064c8fb5892366c103e328079318f78062f24ea8c9d50bc6a47aa3567cabefd824d170e78fa2745ed1f16b132e16436146b7688f19b"
}
1 change: 0 additions & 1 deletion packages/oidc-signin-tool/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"@itwin/core-common": "^3.3.0 || ^4.0.0",
"@itwin/service-authorization": "workspace:^",
"@playwright/test": "~1.41.0",
"crypto-browserify": "^3.12.0",
"dotenv": "^10.0.0",
"dotenv-expand": "^5.1.0",
"oidc-client-ts": "^2.4.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export class TestBrowserAuthorizationClient implements AuthorizationClient {
try {
await this.signIn();
} catch (err) {
console.log("Error signing in", err);
// rethrow error if hit max number of retries or if it's not a navigation failure (i.e. a flaky failure)
if (
numRetries === 2 ||
Expand All @@ -90,6 +91,7 @@ export class TestBrowserAuthorizationClient implements AuthorizationClient {
)
throw err;
numRetries++;
console.log("Retrying sign in");
continue;
}

Expand Down Expand Up @@ -149,9 +151,9 @@ export class TestBrowserAuthorizationClient implements AuthorizationClient {
resultFromCallback: async (callbackUrl) => {
const tokenSet = await oidcClient.processSigninResponse(callbackUrl);
this._accessToken = `Bearer ${tokenSet.access_token}`,
this._expiresAt = tokenSet.expires_at !== undefined
? new Date(tokenSet.expires_at * 1000)
: undefined;
this._expiresAt = tokenSet.expires_at !== undefined
? new Date(tokenSet.expires_at * 1000)
: undefined;
},
});
}
Expand Down
Loading