Closed
Conversation
pankhur94
requested review from
MichaelSwigerAtBentley,
anmolshres98,
aruniverse and
ben-polinsky
as code owners
aruniverse
reviewed
May 29, 2025
| import { getConfig, getMockTokenResponse, setupMockAuthServer, stubTokenCrypto } from "./helpers/testHelper"; | ||
| /* eslint-disable @typescript-eslint/naming-convention */ | ||
| const assert = chai.assert; | ||
| const assert: Chai.AssertStatic = chai.assert; |
Member
There was a problem hiding this comment.
whats the need for the explicit typing?
you could probably do the following
const { assert, expect } = chai;
Contributor
Author
There was a problem hiding this comment.
I tried this but this does not work because ts does not track types through namespace destructuring. expect works fine because it does not call a method directly and is generally chained unlike assert.
aruniverse
approved these changes
May 29, 2025
MichaelSwigerAtBentley
approved these changes
May 29, 2025
Member
|
I initially approved this thinking we could avoid a major version bump; but after reading iTwin/viewer#366 i think we should just bite the bullet and clean up our deps and do a major
maybe we split some of these into separate pr, targeting different pkgs |
This was referenced May 29, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to support core 5.0 since this is causing core-* mismatches in preparing of next version for our viewer.