Skip to content

Fix ReLogin in E2E due to missing locator#332

Merged
bilalbaig3101 merged 4 commits intomainfrom
fix-relogin
Jan 29, 2026
Merged

Fix ReLogin in E2E due to missing locator#332
bilalbaig3101 merged 4 commits intomainfrom
fix-relogin

Conversation

@bilalbaig3101
Copy link
Contributor

@bilalbaig3101 bilalbaig3101 commented Jan 27, 2026

This PR fixes an issue in the E2E tests where relogin fails. On reLogin the function is unable to locate the email input field causing the test to fail.

Root Cause

After the signout the login page shows the already loged out user email instead of email input field which is something login funciton relies on
this is how the login page is showen when cache is cleared
Screenshot 2026-01-26 191324
this is how the login page on re-login and the email locator is missing
Screenshot 2026-01-27 145345

Solution
added a locator to click "Use another accout"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a relogin failure in E2E tests where the email input field locator was missing after signout. The login page displays the previously logged-out user's email instead of an input field, preventing successful relogin.

Changes:

  • Added logic to detect and click "Use another account" button when present on the login page
  • Updated changelog with patch version bump

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/oidc-signin-tool/src/SignInAutomation.ts Added conditional logic to handle "Use another account" flow before filling email field
change/@itwin-oidc-signin-tool-a08681dc-67af-481d-b940-f18e572a33cf.json Added changelog entry for the relogin fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bilalbaig3101 and others added 2 commits January 27, 2026 18:02
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…a33cf.json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@iTwin iTwin deleted a comment from Copilot AI Jan 27, 2026
@ben-polinsky
Copy link
Collaborator

Thanks for the contribution. E2E tests are failing, however. Have you thoroughly tested this?

@bilalbaig3101
Copy link
Contributor Author

Thanks for the contribution. E2E tests are failing, however. Have you thoroughly tested this?

@ben-polinsky re-ran the pipeline all test stages passed this time

@bilalbaig3101 bilalbaig3101 merged commit a49dd41 into main Jan 29, 2026
13 checks passed
@bilalbaig3101 bilalbaig3101 deleted the fix-relogin branch January 29, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants