Skip to content

Add native ChangesetReader#1368

Merged
soham-bentley merged 81 commits into
mainfrom
soham/native-ec-adaptor
Apr 27, 2026
Merged

Add native ChangesetReader#1368
soham-bentley merged 81 commits into
mainfrom
soham/native-ec-adaptor

Conversation

@soham-bentley

@soham-bentley soham-bentley commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Comment thread iModelCore/ECDb/ECDb/PreparedECChangesetReader.cpp Outdated
Comment thread iModelCore/ECDb/ECDb/PreparedChangesetReader.cpp
Comment thread iModelCore/ECDb/ECDb/PreparedECChangesetReader.cpp Outdated
Comment thread iModelCore/ECDb/ECDb/ECChangesetReaderImpl.cpp Outdated
Comment thread iModelCore/ECDb/ECDb/ChangesetValueFactory.cpp Outdated
Comment thread iModelCore/ECDb/ECDb/ChangesetValueFactory.cpp Outdated
@soham-bentley

Copy link
Copy Markdown
Contributor Author

/azp run imodel-native

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rschili rschili left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Two PR titles are both different tense from the story title. I suggest we make this a bit more verbose.

iTwin:
Add NativeECChangesetReader API with lazy loading and filtering
native:
Add native ECChangesetReader

@soham-bentley soham-bentley changed the title Implementing native ECChangesetReader Add native ECChangesetReader Apr 15, 2026
Comment thread iModelCore/ECDb/ECDb/PreparedECChangesetReader.h Outdated
Comment thread iModelCore/ECDb/ECDb/PreparedECChangesetReader.h Outdated
Comment thread iModelCore/ECDb/ECDb/ChangesetValueFactory.cpp
@soham-bentley

Copy link
Copy Markdown
Contributor Author

/azp run imodel-native

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

soham-bentley and others added 3 commits April 23, 2026 11:22
NativeChangeset->SqliteChangesetReader
ECChangesetReader -> ChangesetReader
in cpp layer
And in typescript layer
ChangesetReader->SqliteChangesetReader
ECChangesetReader->ChangesetReader
As per Affan's request

Co-authored-by: Copilot <copilot@github.com>
@soham-bentley soham-bentley changed the title Add native ECChangesetReader Add native ChangesetReader Apr 24, 2026
soham-bentley and others added 2 commits April 27, 2026 10:20
@soham-bentley soham-bentley enabled auto-merge (squash) April 27, 2026 06:02
@soham-bentley soham-bentley merged commit b93596d into main Apr 27, 2026
20 checks passed
@soham-bentley soham-bentley deleted the soham/native-ec-adaptor branch April 27, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants